Skip to content

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Oct 6, 2025

Issue number: internal


What is the current behavior?

  • The ionic theme tokens are undefined.
  • The dark palette does not work with the ionic theme.
  • The ionic theme uses different colors than md and ios.
  • The modular theme tokens are not being used by any tests dependent on URL params.

What is the new behavior?

  • Updates the token interface to accept a numeric scale - it is TBD if it will be the way forward but it is needed for the ionic theme currently.
  • Updates the base tokens to use the new interface.
  • Adds tokens for the ionic theme based on the existing design tokens.
  • Excludes certain keys (enabled, rippleEffect, formHighlight) from the generated CSS variables.
  • Removes the --background and --ion-background-color from the global ionic theme overrides, allowing it to use the dark palette.
  • Removes the different Ionic colors from the ionic theme, ensuring all of the themes use the same named (primary, secondary, etc.) colors.
  • Updates the testing script to pull in the tokens based on the theme & palette passed to the URL.
  • Adds a new npm script, build.newTokens, to generate the token files.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview: Basic
Preview: Color
Preview: Typography

Add the URL parameters ?ionic:palette=dark or ?ionic:theme={ios|md|ionic} to see the palette or theme change and pull in the associated tokens.

Note: most of the theme specific tokens are not applied yet because we haven't updated the components.

Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Oct 7, 2025 9:42pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant